fix(web): combobox search input fills its popup - #24312

Approvability

Verdict: Approved at f87fa37

Macroscope's review found this PR approvable — This one-line UI fix makes existing combobox search inputs fill their popup instead of shrinking to intrinsic input width. It is a self-contained layout change with no schema, infrastructure, security, or static-analysis impact.

^{You can add or adjust custom eligibility rules. Learn more.}

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: a0e0f8a
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 18ce7ca3-0c66-4dad-a9c5-6ef1e16e2bc5

Commits

Reviewing files that changed from the base of the PR and between f87fa37 and 4f3168e.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 26c3625
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: b3f866d3-b75c-4867-b0a7-560d09b3493f

Commits

Reviewing files that changed from the base of the PR and between 26c3625 and f87fa37.

Files selected for processing: 1

• apps/web/src/components/ui/combobox.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Merge Risk: Minimal · up to f87fa

The localized sizing change addresses placeholder truncation with no identified adverse behavior.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: making the web combobox search input fill its popup.
Description check		The description explains the problem, cause, fix, scope, verification results, visual evidence, and unchecked areas. It uses different headings from the template, but it provides the required informat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the problem, cause, fix, scope, verification results, visual evidence, and unchecked areas. It uses different headings from the template, but it provides the required information and justifies the focused fix without a prior issue.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

Verified in a real dev environment

Verified unchanged head 4f3168e6fdf2179246c8c258698b313416cb33e5 using repo Playwright and /usr/bin/google-chrome on Linux. Ran vp i and background vp run dev separately for github/main (5ef56853ef) and the exact PR head, with only one dev server running at a time. The PR run used explicit isolated --home-dir /home/user/t3code/.t3.

Created a real git repository, added it as a project through the app, and started a thread using Codex gpt-6.1-sol through the local proxy. No mocks, replay provider, fixtures, or demo data.

The shared search-width bug reproduces in the real model picker on main: the input is 239px inside a 336px search row. On this PR it fills all 336px. The matching query below exposes the extra usable width. At 1024px viewport width, the input also matched its row width.

Filtering models, clearing the filter, Escape dismissal, keyboard selection of GPT-6.1-Sol, and subsequent real provider turns worked. The client displayed after selection verified and recorded selection works. Also exercised branch searching, branch creation in the disposable verification repository, and selection of the existing main branch.

Before, main:

After, PR:

Inspected the captures and checked uploaded video playback and seeking in T3's player.

Blacksmith transcript, using the PR parent explicitly because the worker snapshot has shallow history:

vp run check:changed FETCH_HEAD^
check:changed: 1 files since a0e0f8a80ae4
pass format
pass lint
pass knip 1/2
pass knip 2/2
pass typecheck (2 packages)

No source changes were needed.

Not verified

Native Electron, iOS, Android, macOS/Windows rendering, remote/relay/tunnel connections, other providers, dark theme, and every individual shared-component consumer. The original macOS reviewer-placeholder clipping was not reproduced on this Linux VM; the real model picker demonstrated the same underlying shared-component width defect and fix. The reviewer/label picker was not exercised against an external host.

Thank you, @bryanprimus, for identifying and fixing this! The same combobox search-width fix is now on main in #32926, commit 6417151c09, with your co-author credit. Closing this as covered.